7f9dfde0dc* libmisc/setugid.c (setup_uid_gid): The is_console argument is now a bool. * libmisc/setugid.c: Avoid implicit conversion of integers / pointers to booleans. * libmisc/setugid.c: Add brackets.
nekral-guest
2008-05-25 23:42:39 +00:00
2533c87bd6* libmisc/setugid.c (setup_uid_gid): The is_console argument is no a bool. * libmisc/setugid.c: Avoid implicit conversion of integers / pointers to booleans. * libmisc/setugid.c: Add brackets.
nekral-guest
2008-05-25 23:39:59 +00:00
6fef9f5178* libmisc/pam_pass.c (do_pam_passwd): The silent and change_expired are no booleans instead of int. * libmisc/pam_pass.c: The return value of pam_end is not checked on purpose.
nekral-guest
2008-05-25 23:38:05 +00:00
53bedaa4c1* libmisc/getlong.c: Avoid implicit conversion of pointers / chars to booleans. * libmisc/getlong.c: Add brackets.
nekral-guest
2008-05-25 23:25:33 +00:00
1ebf7842f5* libmisc/valid.c: Avoid implicit conversion of pointers /chars to booleans. * libmisc/valid.c: Add brackets.
nekral-guest
2008-05-25 23:22:15 +00:00
f14452ec3c* libmisc/yesno.c: yes_or_no returns a bool instead of int. * libmisc/yesno.c: Avoid implicit conversion of pointers to booleans. * libmisc/yesno.c: The return value of fflush is not checked on purpose.
nekral-guest
2008-05-25 23:01:14 +00:00
78c0edb7c1(failcheck): The failed argument is a bool.
nekral-guest
2008-05-25 22:54:20 +00:00
f2b4efff20Avoid implicit conversion of integers to booleans.
nekral-guest
2008-05-25 22:51:46 +00:00
11003f5842* libmisc/rlogin.c: Avoid assignments in comparisons. * libmisc/rlogin.c: Avoid implicit conversion of integers to booleans. * libmisc/rlogin.c: Add brackets.
nekral-guest
2008-05-25 22:49:41 +00:00
c638c3cc3d* libmisc/failure.c (failcheck): The failed argument is a bool. * libmisc/failure.c (too_many_failures): too_many_failures returns a bool. * libmisc/failure.c: Add notes about unchecked return values. * libmisc/failure.c: Avoid assignments in comparisons. * libmisc/failure.c: Add brackets.
nekral-guest
2008-05-25 22:44:44 +00:00
a2982f0d4e* libmisc/myname.c: Avoid assignments in comparisons. * libmisc/myname.c: Avoid implicit conversion of pointers / chars to booleans. * libmisc/myname.c: Add brackets.
nekral-guest
2008-05-25 22:15:28 +00:00
7069324a20* libmisc/utmp.c (checkutmp): Change picky argument's type to bool. * libmisc/utmp.c: Use bool when possible (found_utmpx, found_utmp). * libmisc/utmp.c: Add note about unchecked return values.
nekral-guest
2008-05-25 22:11:12 +00:00
9d331bb32b* Change type of added to bool. * Avoid implicit conversion of pointers to booleans.
nekral-guest
2008-05-25 22:03:09 +00:00
bc0657d13c* hushed returns a bool instead of int. * Avoid assignments in comparisons. * (hushed) Change type of found to bool. * Add brackets. * Always check if the user or the shell is in the file. Do not check the first character of the line first. This is simpler and match better with the HUSHLOGIN_FILE documentation.
nekral-guest
2008-05-25 21:52:14 +00:00
712ed48a62* lib/getdef.h, lib/getdef.c: getdef_bool returns a bool instead of int. * lib/getdef.c: Change typo of def_loaded to bool. * lib/getdef.c: Add brackets. * lib/getdef.c: Avoid assignment in comparisons.
nekral-guest
2008-05-25 21:43:05 +00:00
66afec21d1Allow usage of booleans in the source.
nekral-guest
2008-05-25 21:34:38 +00:00
b94825bbad* is_my_tty returns a bool. * Avoid implicit conversion of integers to booleans. * Add brackets.
nekral-guest
2008-05-25 21:33:38 +00:00
06d2a32a3e* Avoid assignment in comparisons, implicit comparison of integers to booleans. * The return value of closedir is not checked on purpose. * Add brackets.
nekral-guest
2008-05-25 21:23:28 +00:00
623d9e2ab3* libmisc/chkname.h, libmisc/chkname.c: check_group_name (resp. check_user_name) renamed to is_valid_user_name (resp. is_valid_group_name). is_valid_user_name and is_valid_group_name return a bool. * src/grpck.c, src/newusers.c, src/usermod.c, src/useradd.c, src/groupmod.c, src/pwck.c, src/groupadd.c: Use is_valid_user_name and is_valid_group_name, following above change. * libmisc/chkname.c: Avoid implicit conversion of chars to booleans. Add brackets and parenthesis.
nekral-guest
2008-05-25 20:58:16 +00:00
cb8d416b37Avoid implicit conversion of integers / pointers to booleans.
nekral-guest
2008-05-25 20:41:13 +00:00
de9bee0354Avoid implicit conversion of integers / pointers to booleans.
nekral-guest
2008-05-25 20:39:31 +00:00
ae75a8c0c1Allow usage of booleans in the source.
nekral-guest
2008-05-25 20:37:51 +00:00
8098f63998Allow --disable-man and --enable-man=no.
nekral-guest
2008-05-25 20:30:45 +00:00
2303ddd0deSet the version to 4.1.2.
nekral-guest
2008-05-24 23:15:47 +00:00
b5b636b8b7Prepare the 4.1.2 release * NEWS: set the release date. * man/po/*.po, po/*.po: Updated PO files.
nekral-guest
2008-05-24 23:03:24 +00:00
6124b59aff* libmisc/copydir.c (remove_tree): As we always use remove_tree followed by rmdir to remove the directory itself, delete also the root directory in remove_tree. * src/userdel.c, src/usermod.c: Do not call rmdir after remove_tree.
nekral-guest
2008-05-24 15:35:15 +00:00
9c41a8ad38* libmisc/fields.c: Avoid assignments in comparisons, assignments with post increments (x++), use of integers as booleans, and explicitly mark blocks with brackets. * libmisc/copydir.c: Likewise. * libmisc/fields.c: Add comments. * libmisc/copydir.c: Mark function whose return value is not checked as such.
nekral-guest
2008-05-24 15:19:02 +00:00
cda1f9a23dSimply passwd_check since it's never used when configured with PAM support.
nekral-guest
2008-05-24 14:11:31 +00:00
0219d72f48* libmisc/list.c: Avoid assignments in comparisons, assignments with post increments (x++), use of integers as booleans, and explicitly mark blocks with brackets.
nekral-guest
2008-05-24 14:09:35 +00:00
d99423405cFix compiler warnings: * libmisc/audit_help.c: Include prototypes.h to get the prototype of audit_help_open. * libmisc/salt.c: Use booleans instead of negating integers. * src/passwd.c: Declare the check_selinux_access prototype and avoid name clashes (change_user -> changed_user; change_uid -> changed_uid; access -> requested_access)
nekral-guest
2008-05-24 13:08:58 +00:00
eeb9592dedUse fputs rather than fprintf for constant strings.
nekral-guest
2008-05-23 20:55:11 +00:00
0120fc10e1Added TODO items.
nekral-guest
2008-05-23 20:47:45 +00:00
b9ac46305fIndicate that login should be executed with "exec login" if called from a shell.
nekral-guest
2008-05-21 18:58:06 +00:00
a917ba4fb9*** security: - generation of SHA encrypted passwords (chpasswd, gpasswd, newusers, chgpasswd; and also passwd if configured without PAM support). The number of rounds and number of salt bytes was fixed to their lower allowed values (resp. configurable and 8), hence voiding some of the advantages of this encryption method. Dictionary attacks with precomputed tables were easier than expected, but still harder than with the MD5 (or DES) methods.
nekral-guest
2008-05-20 13:34:06 +00:00
9c69fe73b1Tag the section which require --enable-shadowgrp or --with-sha-crypt accordingly.
nekral-guest
2008-05-19 22:18:14 +00:00
63228ac1c6SHA_CRYPT_MAX_ROUNDS and SHA_CRYPT_MIN_ROUNDS can only exist if configured with --with-sha-crypt.
nekral-guest
2008-05-19 21:57:48 +00:00
a071d72e48Document the -k, --skel option, and update the -m, --create-home documentation.
nekral-guest
2008-05-19 21:32:19 +00:00
3fed00196cImport Debian patch 487_passwd_chauthtok_failed_message * libmisc/pam_pass.c: Be more verbose and indicate that the password was not changed when pam_chauthtok fails (in addition to the PAM error, which may not be comprehensible for the users).
nekral-guest
2008-05-18 15:06:51 +00:00
fb4271bdf9Import Debian patch 434_login_stop_checking_args_after-- * NEWS, src/login.c (check_flags): Stop checking the arguments after --. The later options will be sent to the shell, and do not need to be checked.
nekral-guest
2008-05-18 14:54:35 +00:00
6a17c2b27f* src/vipw.c, src/su.c, src/newgrp.c: Harmonize the children's SIGSTOP handling. Raise the signal which stopped the child instead of always SIGSTOP.
nekral-guest
2008-05-18 13:41:56 +00:00
c7302b61efMake sure every source files are distributed with a copyright and license. Files with no license use the default 3-clauses BSD license. The copyright were mostly not recorded; they were updated according to the Changelog. "Julianne Frances Haugh and contributors" changed to "copyright holders and contributors".
nekral-guest
2008-04-27 00:40:09 +00:00
8a8072a563If the SULOG_FILE does not exist when an su session is logged, make sure the file is created with group root, instead of using the group of the caller.
nekral-guest
2008-04-27 00:27:59 +00:00
4196525702Allow non-US-ASCII characters in the GECOS fields ("name", "room number", and "other info" fields).
nekral-guest
2008-04-27 00:24:49 +00:00
4d7d6a1a9fFix build failure when configured with audit support. Thanks to Mike Frysinger for reporting it.
nekral-guest
2008-04-16 22:04:46 +00:00
7baffa5e74Ensure that getpwent() is used in setpwent(), getpwent(), endpwend() sequences (ditto for getgrent(), getspent(), and getsgent()). The only real (minor) issue was in login, which kept the passwd file open. * libmisc/entry.c: Remove unneeded setspent() and endspent() (only getspnam is called in the middle). * libmisc/find_new_ids.c: Make sure to close the password and group files with endpwent() and endgrent(). * libmisc/pwdcheck.c: Remove unneeded endspent() (only getspnam() is called before). * src/lastlog.c, src/passwd.c, src/groupmod.c, src/faillog.c, src/groups.c: Make sure to close the password file with endpwent(). * src/login.c: Remove unneeded setpwent() (only xgetpwnam is called before). * src/login.c, src/newgrp.c: Fix typos in comments.
nekral-guest
2008-04-16 21:52:46 +00:00
8e82ae234eAlso fix the detection of the pam and selinux features: Fail if the feature is requested but the library (or header file) could not be found. If nothing is specified, enable the feature only if we can find the library (or header file).
nekral-guest
2008-04-16 21:18:20 +00:00
17cb7c754eDocument --with-selinux as "yes if found" rather than "autodetected" for consistency with other options.
nekral-guest
2008-04-16 20:16:43 +00:00
70bf7cca33Fix the detection of the audit library and header file.
nekral-guest
2008-04-16 20:09:03 +00:00
f89cf0cf20* NEWS, etc/pam.d/Makefile.am: Add chfn, chsh, and userdel to $(pamd_files). Remove the duplicate useradd. And sort alphabetically. Thanks to Mark Rosenstand <mark@borkware.net>. * NEWS: Prepare next release, 4.1.2.
nekral-guest
2008-04-04 18:50:22 +00:00
1dd0a7e836Commit the PO and POTs released with 4.1.1.
nekral-guest
2008-04-03 20:27:37 +00:00
1de80f9457* NEWS, configure.in: Prepare release 4.1.1 * NEWS: Fix the release date of 4.1.0. Was in 2007, not 2008.
nekral-guest
2008-04-02 21:55:27 +00:00
b345316e49Update according to the file under review. Thanks to Jean-Luc Coulon.
nekral-guest
2008-04-02 21:54:23 +00:00
e8a2633984Add TODO items for SELINUX.
nekral-guest
2008-04-02 21:42:04 +00:00
f7a256fc19* src/passwd.c, NEWS: Make SE Linux tests more strict, when the real UID is 0 SE Linux checks will be performed. Thanks to Russell Coker <russell@coker.com.au> * TODO: Added entries regarding SE Linux.
nekral-guest
2008-03-26 22:00:50 +00:00
eca5208c20Added TODO entries.
nekral-guest
2008-03-26 21:44:50 +00:00
fed294e11eUpdated Korean and Portuguese translations
bubulle
2008-03-23 08:39:58 +00:00
04af9cb9f8Fix manpages generation. The SYS_GID_MAX and SYS_UID_MAX entities were not defined.
nekral-guest
2008-03-17 23:07:04 +00:00
32b424e507Fix minor compilation warning (assignment used as a comparison).
nekral-guest
2008-03-17 23:05:59 +00:00
d94602add8login_access() is used in src/login.c, and defined in src/login_nopam.c (which lacks a prototype). Move its prototype from src/login.c to lib/prototypes.h.
nekral-guest
2008-03-17 23:04:46 +00:00
e33e2b7d79Compilation fix. gshadow_locked should only be used if SHADOWGRP is defined.
nekral-guest
2008-03-17 23:02:23 +00:00
78c59b7261Fix some warnings. compare_members_lists() is only used if SHADOWGRP is defined.
nekral-guest
2008-03-17 23:00:49 +00:00
8377303981Remove unused global variable.
nekral-guest
2008-03-08 23:52:50 +00:00
a8a614c515* NEWS, src/groupmod.c: Make sure the passwd, group, and gshadow files are unlocked on exit. Unlock locked files in fail_exit(). Prefer fail_exit() over exit(). * NEWS, src/groupmod.c: When the GID of a group is changed, update also the GID of the passwd entries of the users whose primary group is the group being modified.
nekral-guest
2008-03-08 23:01:49 +00:00
b1a0769d3d* lib/commonio.c (commonio_remove): Fail when the name to be removed is used by different entries (like commonio_update does). * NEWS: This fix the behavior of groupdel when the system is not configured to support split group but different group entries have the name of the group to be deleted.
nekral-guest
2008-03-08 22:52:44 +00:00
1b808e62dfMake sure the passwd, group, shadow, and gshadow files are unlocked on exit. Unlock locked files in fail_exit(). Prefer fail_exit() over exit().
nekral-guest
2008-03-08 22:44:53 +00:00
5af8a5d74d* NEWS, src/groupdel.c: Make sure the group, and gshadow files are unlocked on exit. Add function fail_exit(). Use fail_exit() instead of exit(). * src/groupdel.c: Fail immediately instead of increasing errors. Better handling of error cases, like locked group or gshadow file.
nekral-guest
2008-03-08 21:13:54 +00:00
d1290c0d5dMake sure the passwd, group, shadow, and gshadow files are unlocked on exit. Add function fail_exit(). Use fail_exit() instead of exit().
nekral-guest
2008-03-08 21:04:31 +00:00
bded00fd11Make sure the group and gshadow files are unlocked on exit. Add function fail_exit().
nekral-guest
2008-03-08 20:54:54 +00:00
a2242f6f1bDo not rewrite the group and gshadow file in case of error.
nekral-guest
2008-03-08 16:23:22 +00:00
9e07fec6baDo not log that the group was deleted if an error occurred.
nekral-guest
2008-03-08 16:20:55 +00:00
d44f1dfecaDo not raise an error if the group does not exist in the gshadow file.
nekral-guest
2008-03-08 16:17:07 +00:00
1b2618d688* src/newgrp.c: Add missing end of line in message. * src/newgrp.c: Add audit events for the authentication (AUDIT_GRP_AUTH). Thansk to Peter Vrabec.
nekral-guest
2008-03-07 20:21:15 +00:00
6ea65c8992Only reset the entries of existing users with faillog -r (not all numeric IDs starting from 0). Thanks to Peter Vrabec.
nekral-guest
2008-03-05 00:10:25 +00:00
52cfc3372bFix typo. One "can't open" message is a "can't lock".
nekral-guest
2008-03-04 23:53:00 +00:00
nekral-guest
bubulle